[Lldb-commits] [PATCH] D35356: [zorg] Enable assertions on the linux lldb bot

[Galina via Phabricator via lldb-commits]

gkistanova added a comment.

Hi Pavel,

The patch looks Ok, with a small issue to address before committing.



================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:921
                        scriptExt='.sh',
+                       extra_cmake_args=[],
                        ):
----------------
Please do not use mutable default arguments.
See http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments for more details.



================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:954
     getShellCommandStep(f, name='cmake local',
-                        command=[pathSep + 'cmake' + scriptExt])
+                        command=[pathSep + 'cmake' + scriptExt] + extra_cmake_args)
 
----------------
This is not a blocker for this patch. With all the same, it would be nice to use the CmakeCommand here instead of the ShellCommand.


https://reviews.llvm.org/D35356