[Lldb-commits] [PATCH] D37923: Implement interactive command interruption

[Zachary Turner via lldb-commits]

On Mon, Sep 18, 2017 at 3:13 PM Leonard Mosescu <mosescu at google.com> wrote:

> It's a good question - here's a two part answer:
>
> 1. The actual printing of the output is the longest blocking in many cases
> (as mentioned in the description: the actual data gathering for "target
> module dump symtab" can take 1-2sec, but printing it can take 20min. For
> quick experiment, try dis -p -c 10000).
> 2. This change provides the scaffolding for cooperative interruption that
> can be used were appropriate, not just the printing part. I did this for
> "target" commands (see the changes in CommandObjectTarget.cpp), and it's
> very easy to do the same in other places as needed.
>
>
Makes sense.  Can you try `llvm::line_iterator` then instead of the
hand-splitting?  See `llvm/Support/LineIterator.h`
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170918/a64a9966/attachment.html>