[Lldb-commits] [PATCH] D37930: Use ThreadLauncher to launch TaskPool threads

[Tamas Berghammer via Phabricator via lldb-commits]

tberghammer accepted this revision.
tberghammer added a comment.

Looks good



================
Comment at: source/Utility/TaskPool.cpp:61
+    lldb_private::ThreadLauncher::LaunchThread("task-pool.worker", WorkerPtr,
+                                               this, nullptr, 8 * 1024 * 1024)
+        .Release();
----------------
(nit): Can you create a named constant for the min stack size as just based on this line I would have no idea what does that number do?


https://reviews.llvm.org/D37930