[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

[Greg Clayton via lldb-commits]

> On Sep 11, 2017, at 4:05 PM, Leonard Mosescu <mosescu at google.com> wrote:
> 
> 
> Process already has "Error Process::WillResume()" for this very reason. Just have the Windows mini dump core file plug-in override it. The code in Process::Resume already checks this:
> Status Process::PrivateResume() {
>   Status error(WillResume());
>   // Tell the process it is about to resume before the thread list
>   if (error.Success()) {
>       ...
>     }
>   }
>   return error;
> }
> Problem solved no???
> 
> It would be great, but that also happens too late (by the time PrivateResume() is called the state has been already changed)

We could call Process::WillResume() before Process::PrivateResume() before it changes the state... Probably still need to call it in PrivateResume() since a complex thread plan might start and stop the process many times and the process might crash and there would only be one main Process::Continue, or thread step that kicks off the initial run.

Greg


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170911/379b6f03/attachment.html>