[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 8 16:53:41 PDT 2017

jingham added a comment.

But whatever the solution, you should never use llvm::report_fatal_error.  It's fine to put in an lldb_assert which will assert when the error is hit in the test suite, but not in released lldb's.  After all, the worst that will happen if somebody working on lldb were to leave in a code path that called DoResume without CanResume is that the state of that core file target would be wrong.  That is not an error worth taking down whoever happened to load the lldb framework into their program, or destroying all the other debug sessions or targets active in lldb.


More information about the lldb-commits mailing list