[Lldb-commits] [PATCH] D37527: Fix for bug 34510 - Minidump target does not resolve new symbols correctly
Adrian McCarthy via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 6 14:41:58 PDT 2017
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
This looks fine.
Make sure you've run the LLDB tests. I don't expect this change to have much risk for breaking any of them, but it's a good habit. `ninja check-lldb`
For future patch reviews, please create the diffs with full context (e.g., `git diff -U999999`) and from the root of your source tree so that Phabricator shows paths rather than just file names.
If you're not using arc, make sure you amend your commit so that the description has a line like this:
`Differential Revision: https://reviews.llvm.org/D37527`
Capitalization and spacing are sensitive in those lines. When you push your change, that'll associate the revision with the review and close the review on the Phabricator side.
You can also mention the bug number in the description.
More information about the lldb-commits