[Lldb-commits] [PATCH] D37420: [ABI] Rewrite RegisterIsCalleeSaved

[Saleem Abdulrasool via Phabricator via lldb-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Nice cleanup :-)



================
Comment at: source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:1918
+    .Cases("r12", "r13", "r14", "r15",
+           "rbp", "rbx", "ebp", "ebx", true)
+    .Cases("rip", "eip", "rsp", "esp",
----------------
Would be nice to reoder these to `rbp`, `ebp`, `rbx`, `ebx`.  It is easier to see that you are looking at the 32-bit and 64-bit register names that way due to the association.


https://reviews.llvm.org/D37420