[Lldb-commits] [PATCH] D37295: [lldb] Adjust UpdateExternalModuleListIfNeeded method for the case of *.dwo

[Alexander Shaposhnikov via Phabricator via lldb-commits]

alexshap added a comment.

@clayborg - yeah, many thanks for the comments

> Does this seem like it is a compiler bug

yeah, i think it might be the case, although right now i can't say for sure and i need to consult with the DWO spec

> If this is a long released compiler generating this, then we do need a fix in LLDB since it will be running into these binaries from here on out.

yeah, it's (a long released) compiler (4.0), so this will be this way for some time.

besides fixing things for 4.0 I had another thought why this change could be reasonable - LLDB does a linear scan (inside GetSharedModule (in ModuleList::FindModules))
(in this build configuration the size of ModuleList is poportional to the total number of .dwo files which can be quite large)
and in this particular case this can be avoided (because we don't actually need to load the already loaded module).


Repository:
  rL LLVM

https://reviews.llvm.org/D37295