[Lldb-commits] [PATCH] D35760: Expose active and available platform lists via SBDebugger API

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

This seems fine.  I have a little quibble with the name, inline, and a testing suggestion.



================
Comment at: packages/Python/lldbsuite/test/functionalities/platform/TestPlatformPython.py:32-33
+        # the platform list.
+        self.dbg.SetCurrentPlatform('remote-linux')
+        remote_platform = self.dbg.GetSelectedPlatform()
+        self.assertTrue(remote_platform.IsValid())
----------------
Instead of relying on there always being a remote-linux platform, couldn't you just grab a platform from the Available Platform list make sure it isn't the host platform, and add that?  


Repository:
  rL LLVM

https://reviews.llvm.org/D35760