[Lldb-commits] [PATCH] D35760: Expose active and available platform lists via SBDebugger API
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Sat Jul 22 11:55:02 PDT 2017
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This seems fine. I have a little quibble with the name, inline, and a testing suggestion.
Comment at: packages/Python/lldbsuite/test/functionalities/platform/TestPlatformPython.py:32-33
+ # the platform list.
+ remote_platform = self.dbg.GetSelectedPlatform()
Instead of relying on there always being a remote-linux platform, couldn't you just grab a platform from the Available Platform list make sure it isn't the host platform, and add that?
More information about the lldb-commits