[Lldb-commits] [PATCH] D35607: Extend 'target symbols add' to load symbols from a given file by UUID.

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 19 11:14:08 PDT 2017

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

This seems like an okay change.  You want to make sure that passing the file name and UUID into AddModuleSymbols doesn't override a UUID mismatch against the symbol file however you find it.  It looks like that function does the right thing, but can you add a test for this?

You also need to fix up the error messages (around line 4270.)  At present they assume that the uuid & file option's are mutually exclusive.  It's disconcerting to specify two things and have the error mention only one.

This is more Greg's area than mine, so he should also give it the okay.


More information about the lldb-commits mailing list