[Lldb-commits] [PATCH] D35618: Remove shared_pointer from NativeThreadProtocol

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.

The NativeThread class is useless without the containing process (and in
some places it is already assuming the process is always around). This
makes it clear that the NativeProcessProtocol is the object owning the
threads, and makes the destruction order deterministic (first threads,
then process). The NativeProcess is the only thing holding a thread
unique_ptr, and methods that used to hand out thread shared pointers now
return raw pointers or references.


https://reviews.llvm.org/D35618

Files:
  include/lldb/Host/common/NativeProcessProtocol.h
  include/lldb/lldb-private-forward.h
  source/Host/common/NativeProcessProtocol.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.h
  source/Plugins/Process/Linux/NativeThreadLinux.h
  source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
  source/Plugins/Process/NetBSD/NativeProcessNetBSD.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35618.107289.patch
Type: text/x-patch
Size: 48348 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170719/8105f923/attachment-0001.bin>