[Lldb-commits] [PATCH] D35614: Update API headers.

Bruce Mitchener via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 19 02:20:51 PDT 2017


brucem created this revision.

- Provide API doc for SBProcess::SaveCore.
- Fix typo in SBAttachInfo doc comments.
- SBBreakpointList: Name some variables same as C++.


https://reviews.llvm.org/D35614

Files:
  include/lldb/API/SBAttachInfo.h
  include/lldb/API/SBBreakpoint.h
  include/lldb/API/SBProcess.h


Index: include/lldb/API/SBProcess.h
===================================================================
--- include/lldb/API/SBProcess.h
+++ include/lldb/API/SBProcess.h
@@ -350,7 +350,7 @@
 
   bool IsInstrumentationRuntimePresent(InstrumentationRuntimeType type);
 
-  // Save the state of the process in a core file (or mini dump on Windows).
+  /// Save the state of the process in a core file (or mini dump on Windows).
   lldb::SBError SaveCore(const char *file_name);
 
   //------------------------------------------------------------------
Index: include/lldb/API/SBBreakpoint.h
===================================================================
--- include/lldb/API/SBBreakpoint.h
+++ include/lldb/API/SBBreakpoint.h
@@ -154,9 +154,9 @@
 
   SBBreakpoint FindBreakpointByID(lldb::break_id_t);
 
-  void Append(const SBBreakpoint &sb_file);
+  void Append(const SBBreakpoint &sb_bkpt);
 
-  bool AppendIfUnique(const SBBreakpoint &sb_file);
+  bool AppendIfUnique(const SBBreakpoint &sb_bkpt);
 
   void AppendByID(lldb::break_id_t id);
 
Index: include/lldb/API/SBAttachInfo.h
===================================================================
--- include/lldb/API/SBAttachInfo.h
+++ include/lldb/API/SBAttachInfo.h
@@ -162,7 +162,7 @@
   /// Get the listener that will be used to receive process events.
   ///
   /// If no listener has been set via a call to
-  /// SBLaunchInfo::SetListener(), then an invalid SBListener will be
+  /// SBAttachInfo::SetListener(), then an invalid SBListener will be
   /// returned (SBListener::IsValid() will return false). If a listener
   /// has been set, then the valid listener object will be returned.
   //----------------------------------------------------------------------


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35614.107265.patch
Type: text/x-patch
Size: 1734 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170719/3eabd10b/attachment.bin>


More information about the lldb-commits mailing list