[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 13 04:16:50 PDT 2017

labath marked 2 inline comments as done.
labath added a comment.

In https://reviews.llvm.org/D31172#807180, @jingham wrote:

> Sorry I wasn't clear.  I meant that since the Target knows everything it needs to know to vend the correct Architecture plugin, you should get it from the Target, not the Process.  In general, I think that the highest class in the stack that can vend a plugin is the one that should.

Ah, got it. That sounds like a good idea, I'll switch this over to Target.

Comment at: include/lldb/Core/Architecture.h:19
+  Architecture() = default;
+  virtual ~Architecture() = default;
clayborg wrote:
> Not sure the constructor is needed?
It is, because the default constructor is not emitted automatically if you provide a copy constructor (even a deleted one).


More information about the lldb-commits mailing list