[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

[Pavel Labath via lldb-commits]

On 6 July 2017 at 18:40, Bruno Rosa via Phabricator
<reviews at reviews.llvm.org> wrote:
> brunoalr added a comment.
>
> In https://reviews.llvm.org/D35065#800877, @krytarowski wrote:
>
>> What are the build failures?
>
>
>
>
>   [2397/3183] Building CXX object tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/CMakeFiles/lldbPluginDynamicLoaderPosixDYLD.dir/AuxVector.cpp.o
>   FAILED: tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/CMakeFiles/lldbPluginDynamicLoaderPosixDYLD.dir/AuxVector.cpp.o
>   /usr/bin/c++   -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLIBXML2_DEFINED -DLLDB_USE_BUILTIN_DEMANGLER -DLLVM_BUILD_GLOBAL_ISEL -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIM
>   IT_MACROS -Itools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD -I/home/brosa/llvm/tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD -Itools/lldb/include -I/home/brosa/llvm/tools/lldb/include -Iinclude
>   -I/home/brosa/llvm/include -I/usr/include/python2.7 -I/home/brosa/llvm/tools/clang/include -Itools/lldb/../clang/include -I/usr/include/libxml2 -I/home/brosa/llvm/tools/lldb/source/. -fPIC -fvisibility-
>   inlines-hidden -Werror=date-time -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virt
>   ual-dtor -Wno-comment -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register -Wno-vla-extension -g    -fno-exceptions -fno-rtti -MD -MT tools/lldb/source/Plugins
>   /DynamicLoader/POSIX-DYLD/CMakeFiles/lldbPluginDynamicLoaderPosixDYLD.dir/AuxVector.cpp.o -MF tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/CMakeFiles/lldbPluginDynamicLoaderPosixDYLD.dir/AuxVector
>   .cpp.o.d -o tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/CMakeFiles/lldbPluginDynamicLoaderPosixDYLD.dir/AuxVector.cpp.o -c /home/brosa/llvm/tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/AuxV
>   ector.cpp
>   In file included from /usr/include/powerpc64le-linux-gnu/asm/elf.h:17:0,
>                    from /usr/include/powerpc64le-linux-gnu/asm/sigcontext.h:13,
>                    from /usr/include/powerpc64le-linux-gnu/bits/sigcontext.h:27,
>                    from /usr/include/signal.h:306,
>                    from /home/brosa/llvm/tools/lldb/include/lldb/lldb-types.h:17,
>                    from /home/brosa/llvm/tools/lldb/include/lldb/lldb-private-interfaces.h:17,
>                    from /home/brosa/llvm/tools/lldb/include/lldb/lldb-private.h:17,
>                    from /home/brosa/llvm/tools/lldb/include/lldb/Breakpoint/BreakpointLocationCollection.h:21,
>                    from /home/brosa/llvm/tools/lldb/include/lldb/Breakpoint/BreakpointSite.h:22,
>                    from /home/brosa/llvm/tools/lldb/include/lldb/Breakpoint/BreakpointSiteList.h:21,
>                    from /home/brosa/llvm/tools/lldb/include/lldb/Target/Process.h:29,
>                    from /home/brosa/llvm/tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:17:

<https://reviews.llvm.org/D35113> might help you here, as it removes
the (completely unnecessary) signal.h include from lldb-types.h.
However, using different symbol names than those in system headers is
probably a good idea anyway.