[Lldb-commits] [PATCH] D35083: [TypeSystem] Guard the global	`ASTSourceMap` with a mutex
    Pavel Labath via Phabricator via lldb-commits 
    lldb-commits at lists.llvm.org
       
    Fri Jul  7 01:49:31 PDT 2017
    
    
  
labath added a comment.
I would prefer the unique_lock idea also. Lamdas make the code look ugly.
Alternatively, we could start using thread safety annotations https://clang.llvm.org/docs/ThreadSafetyAnalysis.html, and let clang do the checking for us. I think a number of places could benefit from those. Not saying this is the best example, but since we're already discussing it...
Repository:
  rL LLVM
https://reviews.llvm.org/D35083
    
    
More information about the lldb-commits
mailing list