[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:11
 // C Includes
 #include <fcntl.h>
 #include <sys/stat.h>
----------------
Do you still get the error if you remove these includes?

As far as I can tell they are unused, and this part of the code should not depend on system headers anyway.

If that doesn't help, then we should use a different prefix as joerg suggests.


================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115
   _type:                                                                       \
   name = #_type
   switch (type) {
----------------
If we go about renaming them, then we should change this, as we still want to display the standard name of the entries.


https://reviews.llvm.org/D35065