[Lldb-commits] [PATCH] D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs.

David L. Jones via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 5 21:37:26 PDT 2017

dlj added a comment.

In https://reviews.llvm.org/D34853#798699, @andrewng wrote:

> Hi,
> I believe that this "build mode" is intended for the Visual Studio MSVC build. This build is special in that it can produce builds for multiple configurations, e.g. Debug, Release & RelWithDebInfo, within the same top level build output directory. It is this configuration type that defines the "build mode". This means that the unit tests will only pick up the configuration that matches that of the lit that was run. Without the "build mode" I believe lit might end up running all configurations of unit tests that have been built, which is probably not the intended behaviour.
> Cheers,
> Andrew

Ah, excellent. I suspected something like this.

(I don't usually have access to Windows, and even then I typically use Ninja instead of VS... so cleanups like this could be hit-or-miss, I guess.)



More information about the lldb-commits mailing list