[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 4 10:45:46 PDT 2017

clayborg added a comment.

So std::vector shouldn't be used in a public API. You should make a class that wraps your objects. LLDB's public API has lldb::SBInstruction and lldb::SBInstructionList as examples. std::vector on other systems compiles differently for debug and release builds and things will crash. If you need this via swig for internal kind of stuff, then use a typemap where you map std::vector<T> to a list() with T instances in it in python.

I am a bit confused here as well. Are we exporting a plug-in specific python bindings for the Intel PT data? It seems like it would be nice to wrap this API into the SBTrace or other lldb interface? Am I not understanding this correctly?


More information about the lldb-commits mailing list