[Lldb-commits] [PATCH] D33778: Add a NativeProcessProtocol Factory class

[Kamil Rytarowski via Phabricator via lldb-commits]

krytarowski accepted this revision.
krytarowski added inline comments.
This revision is now accepted and ready to land.


================
Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:87
+  assert(wpid == pid);
+  (void)wpid;
+  if (wpid != pid || !WIFSTOPPED(wstatus)) {
----------------
labath wrote:
> krytarowski wrote:
> > Is this line needed?
> Yes, otherwise you get unused variable warnings in no-asserts build. (Or at least you would get, if I had removed the `wpid != pid` check like I was planning to).
This is right, I viewed a differential commit and it was misleading.


https://reviews.llvm.org/D33778