[Lldb-commits] [PATCH] D34683: [unittests] Add a helper function for getting an input file

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 27 14:40:21 PDT 2017

zturner added inline comments.

Comment at: unittests/Utility/Helpers/TestUtilities.cpp:17
+std::string lldb_private::GetInputFile(llvm::Twine name) {
+  llvm::SmallString<128> result = llvm::sys::path::parent_path(TestMainArgv0);
this should be `const Twine &name`.  Also can you call this `GetInputFilePath()`?  At first I was assuming it would return the contents of the file.


More information about the lldb-commits mailing list