[Lldb-commits] [PATCH] D34400: Move Connection from Core to Host

[Pavel Labath via Phabricator via lldb-commits]

labath updated this revision to Diff 103971.
labath added a comment.

This is how things would look like if we move Connection to Utility instead. I
needed to do two things to make this happen:

- Keep Connection::CreateDefaultConnection in Host (now known as Host::CreateDefaultConnection), because this actually creates concrete instances).
- Move IOObject to Utility as well. Connection interface was depending on this class. Although theoretically a forward declaration could suffice, we still shouldn't depend on stuff forward-declared in another module. The same rationale can apply to this class as well -- it's an abstract interface, which can live in Utility, and all concrete instances can (hopefully) stay in Host.


https://reviews.llvm.org/D34400

Files:
  include/lldb/Core/Connection.h
  include/lldb/Host/File.h
  include/lldb/Host/Host.h
  include/lldb/Host/IOObject.h
  include/lldb/Host/MainLoopBase.h
  include/lldb/Host/Socket.h
  include/lldb/Host/posix/ConnectionFileDescriptorPosix.h
  include/lldb/Host/windows/ConnectionGenericFileWindows.h
  include/lldb/Utility/Connection.h
  include/lldb/Utility/IOObject.h
  source/API/SBCommunication.cpp
  source/Core/CMakeLists.txt
  source/Core/Communication.cpp
  source/Core/Connection.cpp
  source/Host/CMakeLists.txt
  source/Host/common/Host.cpp
  source/Host/common/IOObject.cpp
  source/Host/posix/ConnectionFileDescriptorPosix.cpp
  source/Utility/CMakeLists.txt
  source/Utility/Connection.cpp
  source/Utility/IOObject.cpp
  tools/lldb-server/Acceptor.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34400.103971.patch
Type: text/x-patch
Size: 11839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170626/e7d6f9a4/attachment-0001.bin>