[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

Ravitheja Addepally via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 26 08:01:09 PDT 2017


ravitheja added inline comments.


================
Comment at: source/Plugins/Process/Linux/ProcessorTrace.cpp:393
+  llvm::SmallVector<MutableArrayRef<uint8_t>, 2> parts = {
+      src.slice(src_cyc_index), src.drop_back(src.size() - src_cyc_index)};
+
----------------
labath wrote:
> Isn't the drop-back expression equivalent to `src.take_front(src_cyc_index)`?
The problem with that is I don't see the documentation of some functions and I have to dig in the code.
Which is why I did not used it.


https://reviews.llvm.org/D33674





More information about the lldb-commits mailing list