[Lldb-commits] [PATCH] D33998: Add pretty-printer for wait(2) statuses and modernize the code handling them

[Eugene Zemtsov via Phabricator via lldb-commits]

eugene added inline comments.


================
Comment at: source/Host/common/Host.cpp:1010
+    static constexpr char type[] = "WXS";
+    OS << formatv("{0}{1:x-2}", type[WS.type], WS.status);
+    return;
----------------
 type[WS.type] seems to be a somewhat unnecessary hack. I would use a simple switch here.


================
Comment at: source/Host/common/Host.cpp:1017
+      {"Exited with status"}, {"Killed by signal"}, {"Stopped by signal"}};
+  OS << desc[WS.type] << " " << int(WS.status);
+}
----------------
Same as above.


https://reviews.llvm.org/D33998