[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 8 05:30:55 PDT 2017

labath added a comment.

Thanks for the review. I'm not entirely proud of how I implemented this, but I hope it's not too ugly either. The reason I opted for this approach is that I needed to implement the "if the module is null then decrement the address and recompute" logic in two places. RegisterContextLLDB (computes the backtrace) and StackFrame (computes the symbol name to display). This avoids the duplication, but adds another argument to a bunch of functions. I don't really have an idea on how to make this better, but maybe you will think of something.


More information about the lldb-commits mailing list