[Lldb-commits] [lldb] r303907 - Fix bug #28898

Christos Zoulas via lldb-commits lldb-commits at lists.llvm.org
Tue May 30 08:44:13 PDT 2017


On May 29,  8:11pm, Ulrich.Weigand at de.ibm.com ("Ulrich Weigand") wrote:
-- Subject: Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

| Sorry, this is on an internal IBM machine ... I don't have a publically
| accessible machine to reproduce this on at the moment.

I am sorry to say that this is my fault and this sucks. I accepted
some patches that broke binary compatibility in a way that it is not
user visible. Basically you seem to have version of libedit that is
between the narrow one that works, and the wide one that has the
binary compatibility of the wide code removed.

| I managed to debug a bit myself, and I think the problem is this:

Yes, this is correct. Basically your version of libedit handles
properly the narrow char read function and breaks if it is defined
as a wide char. if your histedit header does not have EL_ALIAS_TEXT
defined, you can check for that define too and not use the wide read
if that is not defined. Unfortunately there was no other change in
the version that would help differentiating the two libedit versions.

To fix this properly we would require an updated version of libedit.

christos


More information about the lldb-commits mailing list