[Lldb-commits] [PATCH] D33812: [TypeSystem] Handle Clang AttributedTypes

[Sean Callanan via Phabricator via lldb-commits]

spyffe created this revision.

When parsing types originating in modules, it is possible to encounter `AttributedType`s (such as the type generated for `NSString *_Nonnull`).  Some of LLDB's `ClangASTContext` methods deal with them; others do not.  In particular, one function that did not was `GetTypeInfo`, causing `TestObjCNewSyntax` to fail.

This fixes that, treating `AttributedType` as essentially transparent and getting the information for the modified type.

In addition, however, `TestObjCNewSyntax` is a monolithic test that verifies a bunch of different things, all of which can break independently of one another.  I broke it apart into smaller tests so that we get more precise failures when something (like this) breaks.


Repository:
  rL LLVM

https://reviews.llvm.org/D33812

Files:
  packages/Python/lldbsuite/test/lang/objc/objc-new-syntax/TestObjCNewSyntax.py
  source/Symbol/ClangASTContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33812.101140.patch
Type: text/x-patch
Size: 7051 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170602/8c083e22/attachment.bin>