[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

[Ed Maste via Phabricator via lldb-commits]

emaste added a comment.

Generally LGTM with two questions inline.



================
Comment at: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:45
+        os.mkdir(os.path.join(os.getcwd(),'newdir'))
+        self.buildProgram('main.cpp','newdir/proc_attach')
+        exe = os.path.join('.','newdir','proc_attach')
----------------
Does this one need to use `os.path.join` too?


================
Comment at: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:53
+
+        os.chdir('newdir')
+        self.runCmd("process attach -p " + str(popen.pid))
----------------
Does the test infra automatically start each test in the correct directory? (I.e., chdir back to the original directory is not required?)


https://reviews.llvm.org/D32522