[Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri May 26 04:10:11 PDT 2017

labath added a comment.

thanks for the effort. I found the logic of the test quite difficult to follow, with multiple breakpoints and notify_calls(). Instead of trying to point out each problem, I figured it will be easier to write my take on how the test could look like: https://paste.ubuntu.com/24665770/.  Besides making the logic flow nicer (I hope), it also avoids a couple of other potentially problematic spots in your test (reliance on the exact way we number threads, potentially infinite loop in the thread.StepInstruction calls, etc).

Let me know what you think.


More information about the lldb-commits mailing list