[Lldb-commits] [PATCH] D33283: RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false

[Pavel Labath via Phabricator via lldb-commits]

labath updated this revision to Diff 100099.
labath added a comment.

Fixed version.

The original patch caused a regression in TestLoadUnload, which has only showed
up when running the remote test suite. The problem there was that we interrupted
the target just as it has hit the rendezvous breakpoint in the dlopen call. This
meant that the stop reason was set to "breakpoint" even though the event would
not have been broadcast if we had not stopped the process. I fix this by
checking StopInfo->ShouldNotify() before stopping.

I was hoping I would be able to create a more reliable test for this bug by
calling an expression which will hit a conditional breakpoint, whose condition
will evaluate to false. However, I have found that this does not work at all --
we always stop at the breakpoint, regardless of the expression. So, I add a
(disabled) test for that instead.


https://reviews.llvm.org/D33283

Files:
  packages/Python/lldbsuite/test/expression_command/unwind_expression/TestUnwindExpression.py
  packages/Python/lldbsuite/test/expression_command/unwind_expression/main.cpp
  source/Target/Process.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33283.100099.patch
Type: text/x-patch
Size: 13041 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170524/3f11ca86/attachment-0001.bin>