[Lldb-commits] [lldb] r303677 - Fix bad change in RenderScriptx86ABIFixups.cpp, forgot to change everything necessary

Stephane Sezer via lldb-commits lldb-commits at lists.llvm.org
Tue May 23 12:22:31 PDT 2017


Author: sas
Date: Tue May 23 14:22:31 2017
New Revision: 303677

URL: http://llvm.org/viewvc/llvm-project?rev=303677&view=rev
Log:
Fix bad change in RenderScriptx86ABIFixups.cpp, forgot to change everything necessary

Summary: I didn't change all instances of i to I in this loop. I am a bad person and should feel bad. :(

Reviewers: sas

Differential Revision: https://reviews.llvm.org/D33456

Change by Alex Langford <apl at fb.com>

Modified:
    lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp

Modified: lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp?rev=303677&r1=303676&r2=303677&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp (original)
+++ lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp Tue May 23 14:22:31 2017
@@ -257,9 +257,9 @@ bool fixupRSAllocationStructByValCalls(l
     for (unsigned I = call_attribs.index_begin(); I != call_attribs.index_end();
          I++) {
       // if this argument is passed by val
-      if (call_attribs.hasAttribute(i, llvm::Attribute::ByVal)) {
+      if (call_attribs.hasAttribute(I, llvm::Attribute::ByVal)) {
         // strip away the byval attribute
-        call_inst->removeAttribute(i, llvm::Attribute::ByVal);
+        call_inst->removeAttribute(I, llvm::Attribute::ByVal);
         changed = true;
       }
     }




More information about the lldb-commits mailing list