[Lldb-commits] [PATCH] D33426: Introduce new command: thread unique-stacks

Brian Gianforcaro via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon May 22 20:22:50 PDT 2017


bgianfo updated this revision to Diff 99844.
bgianfo marked 3 inline comments as done.
bgianfo added a comment.

This iteration addresses Jim's feedback.

I've updated all of the code to match the surrounding style where
I missed it originally. (branches/variable names)

I also moved the command under "thread backtrace unique".
This required refactoring the thread iterator command object.
I've tried to reuse as much as code possible in the thread iterator
so that we actually use HandleOneThread to push the rending of
of the call stack down to the BackTrace command.

The bucketing has been moved directly into the command iterator
when he user passes in the "unique" option.


https://reviews.llvm.org/D33426

Files:
  include/lldb/Target/Thread.h
  source/Commands/CommandObjectThread.cpp
  source/Core/Debugger.cpp
  source/Target/Thread.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33426.99844.patch
Type: text/x-patch
Size: 11584 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170523/0479ac18/attachment.bin>


More information about the lldb-commits mailing list