[Lldb-commits] [PATCH] D32585: Implementation of remote packets for Trace data.

[Ravitheja Addepally via Phabricator via lldb-commits]

ravitheja added a comment.

>   TraceOptions opt;
>   opt.setType(...);
>   opt.setBufferSize(...);
>   opt.setMetaBufferSize(); // with an appropriate TraceOptions constructor, this could be a one-liner
>     std::future<user_id_t> result = std::async(std::launch::async, [&] {
>       return client.StartTrace(opt, error);
>     });
>   HandlePacket(server, "JTrace:start:type:dead:buffersize:beef:metabuffersize:baad:threadid:f00d:jparams:...", "47");
>   ASSERT_EQ(47, result.get());
>   ASSERT_TRUE(error.Success());
> 
> 
> This depends on the packet code being in GdbRemoteCommunicationClient and not ProcessGdbRemote as it is now, but moving it there is a good idea anyway -- ProcessGdbRemote should do higher level stuff, packet parsing should be left in the GDBRCClient.
> 
> The server side code unfortunately cannot be tested this way, but I believe I will get around to enabling that soon as well.

@labath Can I do the unit tests in a seperate patch after this patch ? It would be easier for me and perhaps also easier to review.


https://reviews.llvm.org/D32585