[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon May 15 02:05:51 PDT 2017

labath added a comment.

I don't really like that we are adding a public shared library for every tiny intel feature. Could we at least merge this "plugin" with the existing "intel-mpx plugin" to create one "intel support" library?

Also, adding an external dependency probably deserves a discussion on lldb-dev.

Comment at: tools/CMakeLists.txt:8
+option(LLDB_BUILD_INTEL_PT "Enable Building of Intel(R) Processor Trace Tool" OFF)
clayborg wrote:
> Can we default this to enabled?
We probably can't, as this code depends on a third party library.  In any case, this option should go to LLDBConfig.cmake

Comment at: tools/intel-pt/CMakeLists.txt:42
+add_library(lldbIntelPT SHARED
+  PTDecoder.cpp
any reason you're not using add_lldb_library here?

Comment at: tools/intel-pt/CMakeLists.txt:53
+  target_link_libraries(lldbIntelPT PRIVATE
All of this needs to go away. I think you only needed it because you are plucking NativeProcessLinux internals, so fixing that should fix this too.


More information about the lldb-commits mailing list