[Lldb-commits] [PATCH] D33083: [Expression parser] Look up module symbols before hunting globally

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

The searching code is indeed better and what we now want, but I question of this code should live in ClangExpressionDeclMap::FindGlobalDataSymbol. A better home for this might be in SymbolContext::FindGlobalDataSymbol? Then others can use this functionality. Other clients must want this kind of functionality (other expression parsers). Seems a shame to have it live somewhere where someone would have to copy the code. Thoughts anyone?


https://reviews.llvm.org/D33083