[Lldb-commits] [PATCH] D33083: [Expression parser] Look up module symbols before hunting globally

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Actually, I take that back.  Why do you have to call FindGlobalDataSymbol twice?  Shouldn't FindGlobalDataSymbol do that work for you.  After all you passed in the module.  It should itself prefer symbols in the module...

It also seems wrong that we're just picking the first one in the case where we find two symbols at the same level distant from the current module.  Shouldn't that be an error?


https://reviews.llvm.org/D33083