[Lldb-commits] [PATCH] D33083: [Expression parser] Look up module symbols before hunting globally

Sean Callanan via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 10 18:48:25 PDT 2017


spyffe created this revision.

When it resolved symbol-only variables, the expression parser currently looks only in the global module list.   It should prefer the current module.

I've fixed that behavior by making it search the current module first, and only search globally if it finds nothing.  I've also added a test case.


https://reviews.llvm.org/D33083

Files:
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Makefile
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/One/One.c
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/One/One.h
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/One/OneConstant.c
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/TestConflictingSymbol.py
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Two/Two.c
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Two/Two.h
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Two/TwoConstant.c
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/main.c
  source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33083.98571.patch
Type: text/x-patch
Size: 7585 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170511/6f0178fa/attachment.bin>


More information about the lldb-commits mailing list