[Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

[Kamil Rytarowski via Phabricator via lldb-commits]

krytarowski added inline comments.


================
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:21
+
+  asm volatile ("int3");
+  delay = false;
----------------
int3 is specific to x86.

Some instructions to emit software breakpoint in other architectures:
https://github.com/NetBSD/src/commit/c215d1b7d6c1385720b27fd45189b5dea6d6e4aa

Also there is a support for threads, this is not as portable as it could be. The simplest example could be without them, and threads in debuggee could be tested in dedicated regression tests. This will help out to sort bugs with threads from other features.


================
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:16
+  pid = stoi(elements["pid"], nullptr, 16);
+  parent_pid = stoi(elements["parent-pid"], nullptr, 16);
+  real_uid = stoi(elements["real-uid"], nullptr, 16);
----------------
labath wrote:
> StringRef::getAsInteger
`std::stoi` throws exceptions


https://reviews.llvm.org/D32930