[Lldb-commits] [PATCH] D32820: Parallelize demangling

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

What are the measured improvements here? We can't slow things down on any platforms. I know MacOS didn't respond well to making demangling run in parallel. I want to see some numbers here. And please don't quote numbers with tcmalloc or any special allocator unless you have a patch in  LLDB already to make this a build option.



================
Comment at: source/Symbol/Symtab.cpp:233-239
+  // Don't let trampolines get into the lookup by name map
+  // If we ever need the trampoline symbols to be searchable by name
+  // we can remove this and then possibly add a new bool to any of the
+  // Symtab functions that lookup symbols by name to indicate if they
+  // want trampolines.
+  if (symbol.IsTrampoline())
+    return;
----------------
Not being able to search for symbols by name when they are trampolines? If you lookup symbols by name I would expect things not to fail and I would expect that I would get all the answers, not just ones that are omitted for performance reasons. I would also not expect to have to specify extra flags. Please remove


Repository:
  rL LLVM

https://reviews.llvm.org/D32820