[Lldb-commits] [PATCH] D32832: Make ConstString creation and access lockfree

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I have feeling you gave up on the llvm change too quickly. My interpretation of that thread was that there was general support for the hash function switch, and people only wanted some confirmation it will not regress.

However, I do believe that this can be made faster than any solution based on a generic string map (but I don't like hardcoding bucket numbers either). For a change of this depth, I also think it would be fair to ask for some ConstString unit tests, so we have something we can run thread sanitizer on, instead of tracking down obscure debugger failures.



================
Comment at: source/Utility/ConstString.cpp:58
+  typedef std::atomic<Entry *> StringPool;
+  typedef Entry StringPoolEntryType;
 
----------------
s/StringPoolEntryType/Pool::Entry/ instead of the typedef?


Repository:
  rL LLVM

https://reviews.llvm.org/D32832