[Lldb-commits] [PATCH] D32832: Make ConstString creation and access lockfree

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 3 15:16:11 PDT 2017

clayborg added a comment.

Sorry missed your first note about perf. This has to be able to handle any number of strings efficiently and growing buckets is probably needed. How many buckets are you starting with here? The design probably shouldn't take up gobs of memory if it just has a few strings as well.

Do we really need to use a homegrown hash table here? Can we not leverage std::unordered_map or some other hash table in LLVM here?



More information about the lldb-commits mailing list