[Lldb-commits] [PATCH] D32626: Make the symbol demangling loop order independent

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 28 03:32:41 PDT 2017


labath added a comment.

If you're going to be making drastic changes here, could you please look at the possibility of making a more targeted test, rather than relying on the "run the whole debugger and set a breakpoint" type of tests to verify the finer details of the implementation. I was able to do a unit test for a bug in elf parsing code in https://reviews.llvm.org/D32434, which is not that far from here. That gives me hope it may be possible, but it's hard to say without knowing what kind of changes you would like to make.


Repository:
  rL LLVM

https://reviews.llvm.org/D32626





More information about the lldb-commits mailing list