[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 27 14:05:20 PDT 2017


jingham added a comment.

That test is good.  That tests the lazy lookup of the dwarf type indices.  The other thing this changes is symbol reading.  Can you also add a similar test that relies on finding a symbol in a shared library we might not have read in?  It probably fine to add it to this test case...  It's unlikely we'll break lazy symbol reading and not also break lazy Dwarf Index building, but you never know.  Other than that, this looks fine to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D32598





More information about the lldb-commits mailing list