[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Making an empty main program and saying I see no difference is not enough testing to enable this. I also don't see the benefit of this path. When LLDB is used for symbolication, it might never actually load any debug info or symbols from modules that are added to a target. Also if there is any DWARF that doesn't have the Apple accelerator tables then the DWARF manually indexes itself by spawning threads that will index a compile unit per thread using a thread pool.. So now if we load all symbols at once, using NUM_CORES threads, and then each DWARF file spins off NUM_CORES threads to index the DWARF we can probably bring the machine to the brink? If this feature does go it, we should add a setting that is disabled by default, but if enabled, uses this new functionality. That way we can get it in, ask people to opt into it and later possibly change the default if all goes well. That is my two cents. I still vote for do as little as possible and only do it when needed. But I can see the desire to do things as you coded them. So I think it should be an option that is off by default, but users can set it in their ~/.lldbinit file.


Repository:
  rL LLVM

https://reviews.llvm.org/D32598