[Lldb-commits] [PATCH] D32568: Protect Proces::GetMemoryRegionInfo and ::GetFileLoadAddress with a lock

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 27 11:01:58 PDT 2017


labath added a comment.

In https://reviews.llvm.org/D32568#739607, @scott.smith wrote:

> In https://reviews.llvm.org/D32568#739190, @labath wrote:
>
> > This is not necessary. NativeProcess classes are only used in lldb-server, which is completely single threaded. If you want to change that, then we should start with a discussion of what you intend to achieve.
>
>
> Let me post the other two changes to start a broader discussion.  We can center the conversation around whether/how to prime the caches; the other two changes naturally follow from that.


All your other changes are client-side, so still think this will not matter, but I'll take a look. :)

I meant to respond to the discussion today, but I got sidetracked by the ipv6 thingy. I'll try to look at that tomorrow.


Repository:
  rL LLVM

https://reviews.llvm.org/D32568





More information about the lldb-commits mailing list