[Lldb-commits] [PATCH] D32441: Remove the home-grown android toolchain file and all references to it

[Tamas Berghammer via Phabricator via lldb-commits]

tberghammer added inline comments.


================
Comment at: www/build.html:474-475
             <p>
-              from inside the unzipped NDK. Toolchains for other architectures can be produced in
-              a similar manner.
+              The NDK also contains a cmake toolchain file, which makes configuring the build much simpler.
+              The compiler, include and library paths will be configured by the
+              toolchain file and all you need to do is to select the
----------------
Can you mention the minimum version of the NDK supported by this approach?


================
Comment at: www/build.html:488-493
+              -DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_HOME/build/cmake/android.toolchain.cmake \<br/>
+              -DANDROID_ABI=arm64-v8a \<br/>
+              -DANDROID_PLATFORM=android-21 \<br/>
+              -DANDROID_ALLOW_UNDEFINED_SYMBOLS=On \<br/>
+              -DLLVM_HOST_TRIPLE=aarch64-unknown-linux-android \<br/>
+              -DCROSS_TOOLCHAIN_FLAGS_NATIVE='-DCMAKE_C_COMPILER=cc;-DCMAKE_CXX_COMPILER=c++' <br/>
----------------
Can you add some instructions about the supported ANDROID_ABI and LLVM_HOST_TRIPLE pairs? I would find it a bit hard to figure them out on my own (especially the correct triple)


================
Comment at: www/build.html:488-493
+              -DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_HOME/build/cmake/android.toolchain.cmake \<br/>
+              -DANDROID_ABI=arm64-v8a \<br/>
+              -DANDROID_PLATFORM=android-21 \<br/>
+              -DANDROID_ALLOW_UNDEFINED_SYMBOLS=On \<br/>
+              -DLLVM_HOST_TRIPLE=aarch64-unknown-linux-android \<br/>
+              -DCROSS_TOOLCHAIN_FLAGS_NATIVE='-DCMAKE_C_COMPILER=cc;-DCMAKE_CXX_COMPILER=c++' <br/>
----------------
tberghammer wrote:
> Can you add some instructions about the supported ANDROID_ABI and LLVM_HOST_TRIPLE pairs? I would find it a bit hard to figure them out on my own (especially the correct triple)
Shouldn't we specify LLVM_TARGETS_TO_BUILD as well to reduce the size of the executable?


================
Comment at: www/build.html:488-493
+              -DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_HOME/build/cmake/android.toolchain.cmake \<br/>
+              -DANDROID_ABI=arm64-v8a \<br/>
+              -DANDROID_PLATFORM=android-21 \<br/>
+              -DANDROID_ALLOW_UNDEFINED_SYMBOLS=On \<br/>
+              -DLLVM_HOST_TRIPLE=aarch64-unknown-linux-android \<br/>
+              -DCROSS_TOOLCHAIN_FLAGS_NATIVE='-DCMAKE_C_COMPILER=cc;-DCMAKE_CXX_COMPILER=c++' <br/>
----------------
tberghammer wrote:
> tberghammer wrote:
> > Can you add some instructions about the supported ANDROID_ABI and LLVM_HOST_TRIPLE pairs? I would find it a bit hard to figure them out on my own (especially the correct triple)
> Shouldn't we specify LLVM_TARGETS_TO_BUILD as well to reduce the size of the executable?
Previously we specified LLVM_TARGET_ARCH as well. Is it not needed anymore?


================
Comment at: www/build.html:498
+              Note that currently only lldb-server is functional on android. The
+              lldb client is supported and unlikely to work.
             </p>
----------------
is *not* supported


https://reviews.llvm.org/D32441