[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

[Scott Smith via Phabricator via lldb-commits]

scott.smith created this revision.

UniqueCStringMap "sorts" the entries for fast lookup, but really it only cares about uniqueness.  ConstString can be compared by pointer along, rather than with strcmp, resulting in much faster comparisons.  Change the interface to take ConstString instead, and propagate use of the type to the callers where appropriate.


Repository:
  rL LLVM

https://reviews.llvm.org/D32316

Files:
  include/lldb/Core/UniqueCStringMap.h
  include/lldb/Interpreter/Property.h
  include/lldb/Symbol/ObjectFile.h
  include/lldb/Utility/ConstString.h
  source/Interpreter/OptionValueEnumeration.cpp
  source/Interpreter/OptionValueProperties.cpp
  source/Interpreter/Property.cpp
  source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp
  source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
  source/Plugins/ObjectFile/ELF/ObjectFileELF.h
  source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
  source/Plugins/SymbolFile/DWARF/NameToDIE.cpp
  source/Plugins/SymbolFile/DWARF/NameToDIE.h
  source/Symbol/ClangASTContext.cpp
  source/Symbol/GoASTContext.cpp
  source/Symbol/Symtab.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32316.96031.patch
Type: text/x-patch
Size: 42096 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170420/7c992604/attachment-0001.bin>