[Lldb-commits] [lldb] r300834 - Make TestStaticVariables XFAIL more specific

[Pavel Labath via lldb-commits]

Author: labath
Date: Thu Apr 20 06:28:07 2017
New Revision: 300834

URL: http://llvm.org/viewvc/llvm-project?rev=300834&view=rev
Log:
Make TestStaticVariables XFAIL more specific

The test fails because an older clang did not emit the required debug
info (I am not sure when this got added, but clang-3.7 certainly did not
work yet). The actual platform has nothing to do with this.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py?rev=300834&r1=300833&r2=300834&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py Thu Apr 20 06:28:07 2017
@@ -60,10 +60,9 @@ class StaticVariableTestCase(TestBase):
         compiler=["gcc"],
         bugnumber="Compiler emits incomplete debug info")
     @expectedFailureAll(
-        oslist=['linux'])
-    @expectedFailureAll(
-        oslist=['freebsd'],
-        bugnumber='llvm.org/pr20550 failing on FreeBSD-11')
+        compiler=["clang"],
+        compiler_version=["<", "3.8"],
+        bugnumber='llvm.org/pr20550')
     @add_test_categories(['pyapi'])
     def test_with_python_api(self):
         """Test Python APIs on file and class static variables."""
@@ -102,11 +101,11 @@ class StaticVariableTestCase(TestBase):
             if name == 'g_points':
                 self.assertTrue(
                     val.GetValueType() == lldb.eValueTypeVariableStatic)
-                self.assertTrue(val.GetNumChildren() == 2)
+                self.assertEqual(val.GetNumChildren(), 2)
             elif name == 'A::g_points':
                 self.assertTrue(
                     val.GetValueType() == lldb.eValueTypeVariableGlobal)
-                self.assertTrue(val.GetNumChildren() == 2)
+                self.assertEqual(val.GetNumChildren(), 2)
                 child1 = val.GetChildAtIndex(1)
                 self.DebugSBValue(child1)
                 child1_x = child1.GetChildAtIndex(0)