[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

It looks like you had a fun day yesterday. :)  Unfortunately, I have to add to your problems, as I've had to revert your commit due to a fairly big problem.

The problem that it can happen that the create-a-bunch-of-listening-sockets loop can sometimes only create an ipv6 socket if the respective ipv4 port is used by another process. Then the connecting side will try to connect to the IPv4 port and fail. I am not really sure what would be the best fix for this, but right now this is making our test suite completely unusable...

There was also an issue with not detecting ppoll properly, but that one was easy to fix.

I am sorry, I should have caught this earlier, but you seemed so certain of what you are doing that I did not bother trying to test the patch... :/



================
Comment at: lldb/trunk/cmake/modules/LLDBConfig.cmake:435
 find_package(Backtrace)
+check_symbol_exists(ppoll poll.h HAVE_PPOLL)
 
----------------
This needs `set(CMAKE_REQUIRED_DEFINITIONS -D_GNU_SOURCE)` to detect ppoll on linux.


================
Comment at: lldb/trunk/source/Host/common/TCPSocket.cpp:189
+    // enable local address reuse
+    SetOptionReuseAddress();
 
----------------
This has no effect now as we are not listening on the file descriptor internal to this object.


Repository:
  rL LLVM

https://reviews.llvm.org/D31823