[Lldb-commits] [PATCH] D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 18 09:06:18 PDT 2017

clayborg resigned from this revision.
clayborg added a reviewer: jingham.
clayborg added a comment.

Jim, can you take a look at this and see if this could be fixed in a nicer way? I would prefer to not see anything related to delay slots in a test. Can we abstract this better? Maybe ask the SBInstruction() if you can set a breakpoint on it instead of speaking in delay slot terms? Or maybe we ask the SBInstructionList to count the number of instructions between two addresses? Maybe something like:

  uint32_t SBInstructionList::GetInstructionCount(const SBAddress &start, const SBAddress &end); 

Or improve the test so it doesn't rely on instruction count??


More information about the lldb-commits mailing list