[Lldb-commits] [PATCH] D32080: Introduce FPR and Debug Registers/NetBSD/amd64 support

Kamil Rytarowski via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 18 06:02:42 PDT 2017

krytarowski added inline comments.

Comment at: source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:22
+// clang-format off
+#include <sys/types.h>
labath wrote:
> It is enough to place an empty line between the block's of includes that cannot be reordered (perhaps with a comment saying why).
Thanks this is another option. I prefer to keep style form for NetBSD-specific files to ensure that things will work correctly.

Perhaps it's just sufficient to place <sys/types.h> on top.. but maybe it will be refactored later once this code will get more features.



More information about the lldb-commits mailing list